Reenable watcher rest tests#53532
Merged
martijnvg merged 2 commits intoelastic:masterfrom Mar 13, 2020
Merged
Conversation
This reverts commit 3494c73.
…inning of a test. Relates to elastic#53177
martijnvg
added
>test
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Watcher) |
jakelandis
approved these changes
Mar 13, 2020
Contributor
jakelandis
left a comment
jakelandis
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care of this!
Member
Author
|
I will backport on monday in order to avoid reverting twice if tests turn out to be unstable. |
martijnvg
added a commit
that referenced
this pull request
Mar 16, 2020
Also log a message instead of failing if there are active watches at a beginning of a test. Relates to #53177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and log a message instead of failing if there are active watches at a beginning of a test.
Relates to #53177